$npx -y skills add a-pavithraa/springboot-skills-marketplace --skill code-reviewerReviews Java 25 and Spring Boot 4 codebases, pull requests, files, and modules for migration risks, architecture boundary violations, JSpecify null-safety issues, security flaws, performance regressions, and Spring Data pitfalls. Use when the task is a concrete Java or Spring cod
| 1 | # Java 25 and Spring Boot 4 Reviewer |
| 2 | |
| 3 | ## Purpose |
| 4 | |
| 5 | Use this skill to run a structured review of Java 25 and Spring Boot 4 code. Keep findings grounded in the actual codebase and use the reference files only for the focus areas that apply. |
| 6 | |
| 7 | ## Critical rules |
| 8 | |
| 9 | - Never review without code context. Ask for files, diffs, or the relevant module if none is provided. |
| 10 | - Always cite file paths and line numbers for findings. |
| 11 | - Treat Java 25 and Spring Boot 4 as the target baseline unless the build files show otherwise. |
| 12 | - Analyze workload before recommending virtual threads, reactive rewrites, or architecture changes. |
| 13 | - Use JSpecify as the preferred null-safety baseline for new Boot 4 code, but confirm whether the codebase is still in transition before flagging every legacy annotation. |
| 14 | - Prefer official Spring and Java guidance when a claim depends on framework behavior. |
| 15 | |
| 16 | ## Workflow |
| 17 | |
| 18 | ### Step 1: Confirm scope |
| 19 | |
| 20 | Collect the minimum context required to review accurately: |
| 21 | |
| 22 | 1. Scope: single file, module, PR, or full codebase. |
| 23 | 2. Target versions: confirm Java and Spring Boot versions from the build files when relevant. |
| 24 | 3. Focus areas: migration, architecture, data access, security, performance, null-safety, or all. |
| 25 | 4. Testing context: whether the user expects review findings only or also fix suggestions and test impact. |
| 26 | |
| 27 | ### Step 2: Load only the references that match the review |
| 28 | |
| 29 | Load references just in time: |
| 30 | |
| 31 | | Focus | Read | |
| 32 | |------|------| |
| 33 | | Spring Boot 4 migration patterns and framework deltas | `references/spring-boot-4-patterns.md` | |
| 34 | | Java 25 language and concurrency adoption | `references/java-25-features.md` | |
| 35 | | Security review | `references/security-checklist.md` | |
| 36 | | Performance review | `references/performance-patterns.md` | |
| 37 | | Architecture boundaries and packaging | `references/architecture-patterns.md` | |
| 38 | | Domain model shape | `references/domain-modeling.md` | |
| 39 | | Value-object-heavy designs | `references/value-objects-patterns.md` | |
| 40 | | Null-safety checks | `references/jspecify-null-safety.md` | |
| 41 | |
| 42 | Escalate to another skill when needed: |
| 43 | |
| 44 | - Use `spring-data-jpa` for deep repository, query, and relationship work. |
| 45 | - Use `springboot-migration` for phased upgrade planning or upgrade execution. |
| 46 | |
| 47 | ### Step 3: Run the review passes |
| 48 | |
| 49 | Run only the passes that match the request. For a full review, use this order. |
| 50 | |
| 51 | #### Pass A: Build and configuration |
| 52 | |
| 53 | - Verify Java and Spring Boot versions in `pom.xml` or `build.gradle`. |
| 54 | - Check starter names and migration leftovers. |
| 55 | - Scan for Jackson 3 migration issues, outdated test annotations, and version drift. |
| 56 | |
| 57 | #### Pass B: API correctness |
| 58 | |
| 59 | - Check controller and service boundaries. |
| 60 | - Check validation and error handling. |
| 61 | - Check nullability in public APIs and method overrides. |
| 62 | |
| 63 | #### Pass C: Architecture and packaging |
| 64 | |
| 65 | - Identify the architecture style in use. |
| 66 | - Verify package structure is consistent with that style. |
| 67 | - Flag boundary leaks such as controller-to-repository shortcuts or infrastructure types in domain code. |
| 68 | |
| 69 | #### Pass D: Data access |
| 70 | |
| 71 | - Check repository placement and aggregate boundaries. |
| 72 | - Check for N+1 queries, missing pagination, projection mismatches, and transaction misuse. |
| 73 | |
| 74 | #### Pass E: Security |
| 75 | |
| 76 | - Check authentication and authorization. |
| 77 | - Check input validation and unsafe query patterns. |
| 78 | - Check secrets handling and sensitive logging. |
| 79 | |
| 80 | #### Pass F: Performance and resilience |
| 81 | |
| 82 | - Check caching strategy, unbounded reads, async usage, and remote call behavior. |
| 83 | - Evaluate virtual-thread usage only when the code and workload justify it. |
| 84 | - Check timeouts, retries, and connection-pool assumptions. |
| 85 | |
| 86 | ## Quick triggers for findings |
| 87 | |
| 88 | Use these as review prompts, not as a substitute for code evidence. |
| 89 | |
| 90 | ### Spring Boot 4 and migration |
| 91 | |
| 92 | - old starter names |
| 93 | - old Mockito test annotations |
| 94 | - Jackson 2 assumptions in a Boot 4 codebase |
| 95 | - `TestRestTemplate` usage instead of `RestTestClient` |
| 96 | - manual `HttpServiceProxyFactory` boilerplate instead of `@ImportHttpServices` |
| 97 | - custom API versioning instead of native `spring.mvc.apiversion.*` |
| 98 | - `@ConcurrencyLimit` or native `@Retryable` without `@EnableResilientMethods` |
| 99 | |
| 100 | ### Null-safety |
| 101 | |
| 102 | - missing `package-info.java` where the project uses JSpecify |
| 103 | - lingering `org.springframework.lang` annotations in code that has already moved to JSpecify |
| 104 | - missing copied nullability annotations on overrides |
| 105 | |
| 106 | ### Architecture |
| 107 | |
| 108 | - controllers calling repositories directly |
| 109 | - JPA entities exposed in APIs |
| 110 | - modulith boundary leaks |
| 111 | - business logic concentrated in controllers |
| 112 | |
| 113 | ### Performance |
| 114 | |
| 115 | - entity traversal in loops |
| 116 | - m |