review-pr
starsforks
How to install review-pr?
spencerpauly/skills-repo/review-pr
$npx -y skills add spencerpauly/skills-repo --skill review-prRead a pull request diff like a senior engineer. Flag risk, suggest tests, point out missing edge cases. Use when the user asks to "review PR", "look at this diff", or pastes a GitHub PR URL.
SKILL.md
| 1 | # Review PR |
| 2 | |
| 3 | Read a diff the way a thoughtful senior engineer would. Optimize for **catching bugs and missing tests**, not for nitpicks. |
| 4 | |
| 5 | ## When to use |
| 6 | |
| 7 | - User pastes a GitHub PR URL. |
| 8 | - User says "review this PR", "what do you think of this diff", "ship-check this". |
| 9 | |
| 10 | ## Steps |
| 11 | |
| 12 | 1. **Fetch the diff.** If a URL was given, run `gh pr diff <number>` (or `gh pr view <number> --json files,title,body`). If it's a local branch, `git diff main...HEAD`. |
| 13 | |
| 14 | 2. **Read the description first.** What is this PR trying to accomplish? Hold that intent in mind for the rest of the review. |
| 15 | |
| 16 | 3. **Walk the diff in this order:** |
| 17 | 1. New files / new entry points (highest risk). |
| 18 | 2. Modified business logic. |
| 19 | 3. Tests. |
| 20 | 4. Configuration, dependencies, infra. |
| 21 | |
| 22 | 4. **For each substantive change, check the checklist** in `references/checklist.md`. |
| 23 | |
| 24 | 5. **Write the review** in this shape: |
| 25 | |
| 26 | ```markdown |
| 27 | ## Summary |
| 28 | <one paragraph: what changed, what it's trying to do> |
| 29 | |
| 30 | ## Must-fix |
| 31 | - [ ] <hard bugs, missing error handling, security issues> |
| 32 | |
| 33 | ## Should-fix |
| 34 | - [ ] <missing tests, brittle code, unclear intent> |
| 35 | |
| 36 | ## Nits |
| 37 | - [ ] <style, naming, suggestions — keep these short> |
| 38 | |
| 39 | ## Questions |
| 40 | - <things you genuinely don't understand> |
| 41 | ``` |
| 42 | |
| 43 | 6. **Default posture: approve unless there's a Must-fix.** Senior reviewers unblock; they don't gatekeep. |
| 44 | |
| 45 | ## Don't |
| 46 | |
| 47 | - Don't comment on formatting if the repo has a formatter — that's the linter's job. |
| 48 | - Don't suggest renames unless the existing name is genuinely misleading. |
| 49 | - Don't ask the author to "consider" something — either it's a Must-fix, a Should-fix, or it's not in the review. |
People who liked this also viewed
6 picksType
- find-skillsHelps users discover and install agent skills when they ask questions like "how do I do X", "find a skill for X", "is there a skill that can...", or express interest in extending capabilities. This skSkillsJul 2026
- grill-meA relentless interview to sharpen a plan or design.SkillsJul 2026
- vercel-react-best-practicesVercel's official collection of agent skillsSkillsJul 2026
- improve-codebase-architectureScan a codebase for deepening opportunities, present them as a visual HTML report, then grill through whichever one you pick.SkillsJul 2026
- setup-matt-pocock-skillsConfigure this repo for the engineering skills — set up its issue tracker, triage label vocabulary, and domain doc layout. Run once before first use of the other engineering skills.SkillsJul 2026
- triageMove issues and external PRs through a state machine of triage roles — categorise, verify, grill if needed, and write agent-ready briefs.SkillsJul 2026
