code-review

Name: code-review
Author: tt-a1i

16stars3forks

How to install code-review?

tt-a1i/matt-skills-with-to-goal/code-review

$npx -y skills add tt-a1i/matt-skills-with-to-goal --skill code-review

Installs into the current project.

Summary

Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes — Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/PRD asked for?). Runs both reviews in parallel sub-agent

Files · 1

View on GitHub

SKILL.md

1	Two-axis review of the diff between `HEAD` and a fixed point the user supplies:
2
3	- Standards — does the code conform to this repo's documented coding standards?
4	- Spec — does the code faithfully implement the originating issue / PRD / spec?
5
6	Both axes run as parallel sub-agents so they don't pollute each other's context, then this skill aggregates their findings.
7
8	The issue tracker should have been provided to you — run `/setup-matt-pocock-skills` if `docs/agents/issue-tracker.md` is missing.
9
10	## Process
11
12	### 1. Pin the fixed point
13
14	Whatever the user said is the fixed point — a commit SHA, branch name, tag, `main`, `HEAD~5`, etc. If they didn't specify one, ask for it.
15
16	Capture the diff command once: `git diff <fixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log <fixed-point>..HEAD --oneline`.
17
18	Before going further, confirm the fixed point resolves (`git rev-parse <fixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here — not inside two parallel sub-agents.
19
20	### 2. Identify the spec source
21
22	Look for the originating spec, in this order:
23
24	1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.) — fetch via the workflow in `docs/agents/issue-tracker.md`.
25	2. A path the user passed as an argument.
26	3. A PRD/spec file under `docs/`, `specs/`, or `.scratch/` matching the branch name or feature.
27	4. If nothing is found, ask the user where the spec is. If they say there isn't one, the Spec sub-agent will skip and report "no spec available".
28
29	### 3. Identify the standards sources
30
31	Anything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.
32
33	On top of whatever the repo documents, the Standards axis always carries the smell baseline below — a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:
34
35	- The repo overrides. A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.
36	- Always a judgement call. Each smell is a labelled heuristic ("possible Feature Envy"), never a hard violation — and, like any standard here, skip anything tooling already enforces.
37
38	Each smell reads what it is → how to fix; match it against the diff:
39
40	- Mysterious Name — a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.
41	- Duplicated Code — the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.
42	- Feature Envy — a method that reaches into another object's data more than its own. → move the method onto the data it envies.
43	- Data Clumps — the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.
44	- Primitive Obsession — a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.
45	- Repeated Switches — the same `switch`/`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.
46	- Shotgun Surgery — one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.
47	- Divergent Change — one file or module is edited for several unrelated reasons. → split so each module changes for one reason.
48	- Speculative Generality — abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.
49	- Message Chains — long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.
50	- Middle Man — a class or function that mostly just delegates onward. → cut it, call the real target direct.
51	- Refused Bequest — a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.
52
53	### 4. Spawn both sub-agents in parallel
54
55	Send a single message with two `Agent` tool calls. Use the `general-purpose` subagent for both.
56
57	Standards sub-agent prompt — include:
58
59	- The full diff command and commit list.
60	- The list of standards-source files you found in step 3, plus the smell baseline from step 3 pasted in full — the sub-agent has no other access to it.
61	- The brief: "Report — per file/hunk where relevant — (a) ev

People who liked this also viewed

6 picks

Type

code-review

16stars3forks

View on GitHub

How to install code-review?

tt-a1i/matt-skills-with-to-goal/code-review

$npx -y skills add tt-a1i/matt-skills-with-to-goal --skill code-review

Installs into the current project.

Summary

Files · 1

View on GitHub

SKILL.md

1	Two-axis review of the diff between `HEAD` and a fixed point the user supplies:
2
3	- Standards — does the code conform to this repo's documented coding standards?
4	- Spec — does the code faithfully implement the originating issue / PRD / spec?
5
6	Both axes run as parallel sub-agents so they don't pollute each other's context, then this skill aggregates their findings.
7
8	The issue tracker should have been provided to you — run `/setup-matt-pocock-skills` if `docs/agents/issue-tracker.md` is missing.
9
10	## Process
11
12	### 1. Pin the fixed point
13
14	Whatever the user said is the fixed point — a commit SHA, branch name, tag, `main`, `HEAD~5`, etc. If they didn't specify one, ask for it.
15
16	Capture the diff command once: `git diff <fixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log <fixed-point>..HEAD --oneline`.
17
18	Before going further, confirm the fixed point resolves (`git rev-parse <fixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here — not inside two parallel sub-agents.
19
20	### 2. Identify the spec source
21
22	Look for the originating spec, in this order:
23
24	1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.) — fetch via the workflow in `docs/agents/issue-tracker.md`.
25	2. A path the user passed as an argument.
26	3. A PRD/spec file under `docs/`, `specs/`, or `.scratch/` matching the branch name or feature.
27	4. If nothing is found, ask the user where the spec is. If they say there isn't one, the Spec sub-agent will skip and report "no spec available".
28
29	### 3. Identify the standards sources
30
31	Anything in the repo that documents how code should be written, such as `CODING_STANDARDS.md` or `CONTRIBUTING.md`.
32
33	On top of whatever the repo documents, the Standards axis always carries the smell baseline below — a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:
34
35	- The repo overrides. A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.
36	- Always a judgement call. Each smell is a labelled heuristic ("possible Feature Envy"), never a hard violation — and, like any standard here, skip anything tooling already enforces.
37
38	Each smell reads what it is → how to fix; match it against the diff:
39
40	- Mysterious Name — a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.
41	- Duplicated Code — the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.
42	- Feature Envy — a method that reaches into another object's data more than its own. → move the method onto the data it envies.
43	- Data Clumps — the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.
44	- Primitive Obsession — a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.
45	- Repeated Switches — the same `switch`/`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.
46	- Shotgun Surgery — one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.
47	- Divergent Change — one file or module is edited for several unrelated reasons. → split so each module changes for one reason.
48	- Speculative Generality — abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.
49	- Message Chains — long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.
50	- Middle Man — a class or function that mostly just delegates onward. → cut it, call the real target direct.
51	- Refused Bequest — a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.
52
53	### 4. Spawn both sub-agents in parallel
54
55	Send a single message with two `Agent` tool calls. Use the `general-purpose` subagent for both.
56
57	Standards sub-agent prompt — include:
58
59	- The full diff command and commit list.
60	- The list of standards-source files you found in step 3, plus the smell baseline from step 3 pasted in full — the sub-agent has no other access to it.
61	- The brief: "Report — per file/hunk where relevant — (a) ev

People who liked this also viewed

6 picks

Type